Sep 29, 2015, 02:32 PM
Hi,
glad you like it!
One thing though: I looked over the new code (cause I was curious what you had to change) and I noticed that you changed the function setCookie(..) to not actually append the calculated expiry date to the cookie.
This is problematic because if you do not include the expiry date using "expires" or "max-age", it is only valid until the end of the browser session. See https://developer.mozilla.org/en-US/docs...g_a_cookie for reference.
I decided on 1000 days because that should be adequate for most cases, but looking over the documentation, it appears that "max-age=Infinity" would also be possible.
Here is a screenshot of one of the cookies in Firefox: https://goo.gl/photos/eukD1Ai6wk7DzZc86
~ Josh
glad you like it!
One thing though: I looked over the new code (cause I was curious what you had to change) and I noticed that you changed the function setCookie(..) to not actually append the calculated expiry date to the cookie.
This is problematic because if you do not include the expiry date using "expires" or "max-age", it is only valid until the end of the browser session. See https://developer.mozilla.org/en-US/docs...g_a_cookie for reference.
I decided on 1000 days because that should be adequate for most cases, but looking over the documentation, it appears that "max-age=Infinity" would also be possible.
Here is a screenshot of one of the cookies in Firefox: https://goo.gl/photos/eukD1Ai6wk7DzZc86
~ Josh
